Changes: PvXwiki:Curse noticeboard

Revision as of 20:08, 24 July 2020

The Curse Noticeboard

This is a place where issues that only a Curse Staff member can sort out. These issues will usually pertain to coding problems, relating to our PvXCode, or even the wiki's numerous extensions and special pages.

Please remember that PvXWiki has it's own Admin Noticeboard, and if an issue can be solved by an admin, post the issue there and not here.

To post an issues, please add it to the bottom of the section which the issue belongs, give the issue a suitable heading (Using a level 3 heading (3 ='s either side of the heading) E.G. ===Special:RecentRatings=== if there's a problem with the Recent Ratings page). Underneath the heading, give a brief discription of what's wrong, and sign and date your issue with 4 ~'s.

Note that this is not a talk page and that the respective moderators of each section reserve the right to remove non-administrative comments without discussion.

User Rights issues

This section is for issues related to user rights. Archived issues for this section can be found here.

General issues

Deletion log internal error

Brought to my attention by User:Cyber Smoke, if you go far back enough in the deletion log there's some entry in there which throws an internal database error. https://gwpvx.gamepedia.com/index.php?title=Special:Log/delete&offset=20190620155735&limit=1&type=delete&user= (press "older 1" after this one). Maybe Smoke can clarify if there's some other time when this bug appears or not. -Chieftain Alex (talk) 20:54, 14 April 2020 (UTC)

It's actually on Curse's bug report list, it's caused by a page that somehow had a whitespace at the start of its name. Page itself was deleted so we could use search again, but now the deletion (and move I think) logs will throw the error. -Toraen (talk) 23:40, 14 April 2020 (UTC)

PvX Extension issues

Occasionally tooltips don't display on page load

Kinda hard to debug this one, but sometimes the skill tooltips with "hovertooltip" class don't show the tooltips when hovering. Examination of the browser console suggests that the pvxcode.js code is loading, so I assume this is a timing issue, probably where the javascript finishes loading before the page content (i.e. it applies the tooltip code to the page, finds no elements to add the script to, then the page adds the tooltip nodes, which is too late). Probably replace the with last line on overlib.js with the following

document.addEventListener("DOMContentLoaded", function(event) { 
  overlib2();
});

-Chieftain Alex (talk) 10:57, 12 April 2020 (UTC)

Probably worth noting this seems to occur on firefox way more often than any of the other browsers. -Chieftain Alex (talk) 16:47, 20 June 2020 (UTC)

Rating tab

The rating tab added by Extension:PvXRate 2.0.0.0 (which I've hidden sidewide using CSS, has id #ca-rate) links to the first portion of a build pagename, and for some reason drops anything after slashes (e.g. for "Build:E/Any Stoning" it would link to "?title=Build:E&action=rate". Source seems to be line 112 of PvXRate.hooks.php. Not sure which function I need to replace it with from mw:Manual:Title.php. For the time being I've left the original tab added by the javascript Mediawiki:Hydra.js page (id #special-rate), so there's no functionality change compared with previous. -Chieftain Alex (talk) 20:12, 21 April 2020 (UTC)

Removed Ratings Display

Four votes have been removed here according to Recent Ratings, but I could only see my removed rating until I permanently deleted mine. -Toraen (talk) 13:50, 1 May 2020 (UTC)

As in, only the removed rating showed + there was a box to resubmit it, but none of the other votes appeared on the page for you at all? -Chieftain Alex (talk) 21:28, 1 May 2020 (UTC)

I think that I found the cause. I suspect line 362 of RateAction.php should be using .= - currently it's just using = which will overwrite the additions from the previous loop... this probably means the number of rolledback+displayed votes depends entirely on the order we rollback the votes. -Chieftain Alex (talk) 22:24, 1 May 2020 (UTC)

Voting pages as anon with removed votes

Viewing voting pages when anon doesn't separate removed votes from the valid votes. example link screenshot -Chieftain Alex (talk) 17:52, 20 June 2020 (UTC)

Vote comments with headings

If a voting comment uses wikicode such as "=== heading ===" more than 3x, then a table of contents is created. Additionally a section edit button is "almost" generated, it renders as <mw:sectionedit>section title</mw:sectionedit>. -Chieftain Alex (talk) 17:56, 20 June 2020 (UTC)

Would adding the noeditsection and notoc magic words to the special page fix that? I feel like it should if it's interpreting wikicode already. -Toraen (talk) 20:15, 2 July 2020 (UTC)

lol recentratings

It looks like the most recent account migration/merge has confused this poor extension, as it thinks every vote and rollback happened on July 22nd now. This is probably not a serious issue but I am interested in why it displays that way when going to any vote page shows the correct timestamps for each rating. -Toraen (talk) 10:17, 24 July 2020 (UTC)

Wtf. Why only removed/rollback ratings... -Chieftain Alex (talk) 20:08, 24 July 2020 (UTC)

Solutions to all of the below issues in the green box are captured within this merge request.

Strength and attacks with armor penetration

PvXbig will add a Strength tooltip to these skills even though its effect does not stack with those skills' inherent penetration. Could probably write an exception in for those skills easily enough. -Toraen (talk) 13:57, 23 May 2020 (UTC)

https://gitlab.com/Chieftain_Alex/sandbox/-/blob/master/gwbbcode.inc.php

Added add_strength function to line 1162 and line 1231 to handle the above cases. --Chieftain Alex (talk) 16:36, 20 June 2020 (UTC)

I've copied it to mine, though I will note that technically the bow attacks' penetration can be replaced by Strength's if the latter is higher (I don't think anyone's going to submit a Hambow build anytime soon though so I don't actually care). -Toraen (talk) 10:37, 21 June 2020 (UTC)

Changes live. Maybe someday will fix the ranger skills. -Toraen (talk) 13:54, 25 June 2020 (UTC)

I think I've got it. Requesting check for dumb errors. -Toraen (talk) 23:55, 30 June 2020 (UTC)

Looks good (took me a minute to realise the negation on the preg_match had gone). I did wonder if we need to convert the match into a number, but it seems we did similar stuff all over the gwbbcode.inc.php file anyway. -Chieftain Alex (talk) 15:39, 1 July 2020 (UTC)

Pushed into the merge request. -Toraen (talk) 19:14, 1 July 2020 (UTC)

Oath Shot

Disable duration is supposed to scale 10..5..4s. PvXCode displays an unlinked 10s. -Toraen (talk) 23:01, 30 June 2020 (UTC)

Sacrifice should display as percentage

It's as simple as changing line 647 of gwbbcode.inc.php from:

'value' => $sacrifice

to:

'value' => $sacrifice . "%"

right? -Toraen (talk) 17:38, 2 July 2020 (UTC)

Yes, I can confirm this works to add percentage signs. If you're not bothered by the "%" sign being slightly clipped by the background div image, everything is fine.

If you want to avoid the clipping there are two solutions: (1) Adjust the div size, make skillbg.jpg bigger, change the box sizes and padding, and then upload a new thumbnail image for every single file because it's no longer 40px wide.

OR, (2) set .pvx_attributes {} (line 146 in css/pvxcode.css) from 7px to 1px padding-left. Suggest we do this second option as its easier. -Chieftain Alex (talk) 19:50, 2 July 2020 (UTC)

Implemented 2nd option. -Toraen (talk) 20:00, 2 July 2020 (UTC)

@@ Line 58: / Line 58: @@
 === lol recentratings ===
 It looks like the most recent account migration/merge has confused this poor extension, as it thinks every vote and rollback happened on July 22nd now. This is probably not a serious issue but I am interested in why it displays that way when going to any vote page shows the correct timestamps for each rating. [[User:Toraen|-Toraen]] ([[User talk:Toraen|talk]]) 10:17, 24 July 2020 (UTC)
+: Wtf. Why only removed/rollback ratings... -[[User:Chieftainalex|<span style="font-family:Constantia;color:#D2691E">'''Chieftain '''Alex</span>]] ([[User talk:Chieftainalex|talk]]) 20:08, 24 July 2020 (UTC)
 <!-- new items here -->